Reduce SuspendableObjects

Reduce SuspendableObjects

Objects that don't inherit from suspend/resume don't need to be SuspendableObjects.
They should just inherit from ContextLifecycleObserver instead.

BUG=610176
Committed: https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5
Cr-Commit-Position: refs/heads/master@{#440727}

[haraken, 2016-12-19 08:01:56]

haraken@chromium.org changed reviewers:
+ sigbjornf@opera.com

[haraken, 2016-12-19 08:01:57]

PTAL

[sof, 2016-12-19 09:25:08]

lgtm - a great simplifier!

[haraken, 2016-12-19 09:27:27]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-12-19 09:27:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 10:55:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 10:55:29]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[haraken, 2016-12-19 11:21:57]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-12-19 11:22:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 12:46:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 12:46:03]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[haraken, 2016-12-21 08:32:38]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-12-21 08:33:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 10:07:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 10:07:09]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[haraken, 2016-12-21 11:46:15]

On 2016/12/21 10:07:09, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

ah, those tests are counting # of MediaSession objects by counting # of
SuspendableObjects... I need to rewrite the tests so that they directly count #
of MediaSession objects.

[sof, 2016-12-22 08:05:29]

On 2016/12/21 11:46:15, haraken wrote:
> On 2016/12/21 10:07:09, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
> 
> ah, those tests are counting # of MediaSession objects by counting # of
> SuspendableObjects... I need to rewrite the tests so that they directly count
#
> of MediaSession objects.

For those kinds of tests it would be useful to count per kind; reminds me of
issue 445324.

[haraken, 2016-12-26 02:47:15]

On 2016/12/22 08:05:29, sof wrote:
> On 2016/12/21 11:46:15, haraken wrote:
> > On 2016/12/21 10:07:09, commit-bot: I haz the power wrote:
> > > Try jobs failed on following builders:
> > >   win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
> > >
> >
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
> > 
> > ah, those tests are counting # of MediaSession objects by counting # of
> > SuspendableObjects... I need to rewrite the tests so that they directly
count
> #
> > of MediaSession objects.
> 
> For those kinds of tests it would be useful to count per kind; reminds me of
> issue 445324.

Uploaded a fix: https://codereview.chromium.org/2606633002/

[haraken, 2016-12-26 10:59:05]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-12-26 10:59:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-26 12:49:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-26 12:49:11]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[haraken, 2016-12-27 01:54:32]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-12-27 01:54:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-27 03:27:50]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482803672549980, "parent_rev":
"982ccac0ffb73fbe9b764f6207cf9d35de609a35", "commit_rev":
"1a2d2b2d81d66fd2d3a87d13ec308a258a4e57aa"}

[commit-bot: I haz the power, 2016-12-27 03:28:40]

Description was changed from

==========
Reduce SuspendableObjects

Objects that don't inherit from suspend/resume don't need to be
SuspendableObjects.
They should just inherit from ContextLifecycleObserver instead.

BUG=610176
==========

to

==========
Reduce SuspendableObjects

Objects that don't inherit from suspend/resume don't need to be
SuspendableObjects.
They should just inherit from ContextLifecycleObserver instead.

BUG=610176

Review-Url: https://codereview.chromium.org/2583093002
==========

[commit-bot: I haz the power, 2016-12-27 03:28:41]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2017-01-02 15:45:24]

Description was changed from

==========
Reduce SuspendableObjects

Objects that don't inherit from suspend/resume don't need to be
SuspendableObjects.
They should just inherit from ContextLifecycleObserver instead.

BUG=610176

Review-Url: https://codereview.chromium.org/2583093002
==========

to

==========
Reduce SuspendableObjects

Objects that don't inherit from suspend/resume don't need to be
SuspendableObjects.
They should just inherit from ContextLifecycleObserver instead.

BUG=610176

Committed: https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5
Cr-Commit-Position: refs/heads/master@{#440727}
==========

[commit-bot: I haz the power, 2017-01-02 15:45:25]

Patchset 1 (id:??) landed as
https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5
Cr-Commit-Position: refs/heads/master@{#440727}