Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Side by Side Diff: third_party/WebKit/Source/modules/peerconnection/RTCSessionDescriptionRequestImpl.cpp

Issue 2583093002: Reduce SuspendableObjects (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 28 matching lines...) Expand all
39 #include "public/platform/WebRTCSessionDescription.h" 39 #include "public/platform/WebRTCSessionDescription.h"
40 #include "wtf/RefPtr.h" 40 #include "wtf/RefPtr.h"
41 41
42 namespace blink { 42 namespace blink {
43 43
44 RTCSessionDescriptionRequestImpl* RTCSessionDescriptionRequestImpl::create( 44 RTCSessionDescriptionRequestImpl* RTCSessionDescriptionRequestImpl::create(
45 ExecutionContext* context, 45 ExecutionContext* context,
46 RTCPeerConnection* requester, 46 RTCPeerConnection* requester,
47 RTCSessionDescriptionCallback* successCallback, 47 RTCSessionDescriptionCallback* successCallback,
48 RTCPeerConnectionErrorCallback* errorCallback) { 48 RTCPeerConnectionErrorCallback* errorCallback) {
49 RTCSessionDescriptionRequestImpl* request = 49 return new RTCSessionDescriptionRequestImpl(context, requester,
50 new RTCSessionDescriptionRequestImpl(context, requester, successCallback, 50 successCallback, errorCallback);
51 errorCallback);
52 request->suspendIfNeeded();
53 return request;
54 } 51 }
55 52
56 RTCSessionDescriptionRequestImpl::RTCSessionDescriptionRequestImpl( 53 RTCSessionDescriptionRequestImpl::RTCSessionDescriptionRequestImpl(
57 ExecutionContext* context, 54 ExecutionContext* context,
58 RTCPeerConnection* requester, 55 RTCPeerConnection* requester,
59 RTCSessionDescriptionCallback* successCallback, 56 RTCSessionDescriptionCallback* successCallback,
60 RTCPeerConnectionErrorCallback* errorCallback) 57 RTCPeerConnectionErrorCallback* errorCallback)
61 : SuspendableObject(context), 58 : ContextLifecycleObserver(context),
62 m_successCallback(successCallback), 59 m_successCallback(successCallback),
63 m_errorCallback(errorCallback), 60 m_errorCallback(errorCallback),
64 m_requester(requester) { 61 m_requester(requester) {
65 DCHECK(m_requester); 62 DCHECK(m_requester);
66 } 63 }
67 64
68 RTCSessionDescriptionRequestImpl::~RTCSessionDescriptionRequestImpl() {} 65 RTCSessionDescriptionRequestImpl::~RTCSessionDescriptionRequestImpl() {}
69 66
70 void RTCSessionDescriptionRequestImpl::requestSucceeded( 67 void RTCSessionDescriptionRequestImpl::requestSucceeded(
71 const WebRTCSessionDescription& webSessionDescription) { 68 const WebRTCSessionDescription& webSessionDescription) {
(...skipping 22 matching lines...) Expand all
94 m_successCallback.clear(); 91 m_successCallback.clear();
95 m_errorCallback.clear(); 92 m_errorCallback.clear();
96 m_requester.clear(); 93 m_requester.clear();
97 } 94 }
98 95
99 DEFINE_TRACE(RTCSessionDescriptionRequestImpl) { 96 DEFINE_TRACE(RTCSessionDescriptionRequestImpl) {
100 visitor->trace(m_successCallback); 97 visitor->trace(m_successCallback);
101 visitor->trace(m_errorCallback); 98 visitor->trace(m_errorCallback);
102 visitor->trace(m_requester); 99 visitor->trace(m_requester);
103 RTCSessionDescriptionRequest::trace(visitor); 100 RTCSessionDescriptionRequest::trace(visitor);
104 SuspendableObject::trace(visitor); 101 ContextLifecycleObserver::trace(visitor);
105 } 102 }
106 103
107 } // namespace blink 104 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698