Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: third_party/WebKit/Source/modules/peerconnection/RTCVoidRequestImpl.h

Issue 2583093002: Reduce SuspendableObjects (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 13 matching lines...) Expand all
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #ifndef RTCVoidRequestImpl_h 31 #ifndef RTCVoidRequestImpl_h
32 #define RTCVoidRequestImpl_h 32 #define RTCVoidRequestImpl_h
33 33
34 #include "core/dom/ContextLifecycleObserver.h"
34 #include "core/dom/ExceptionCode.h" 35 #include "core/dom/ExceptionCode.h"
35 #include "core/dom/SuspendableObject.h"
36 #include "platform/heap/Handle.h" 36 #include "platform/heap/Handle.h"
37 #include "platform/peerconnection/RTCVoidRequest.h" 37 #include "platform/peerconnection/RTCVoidRequest.h"
38 38
39 namespace blink { 39 namespace blink {
40 40
41 class RTCPeerConnection; 41 class RTCPeerConnection;
42 class RTCPeerConnectionErrorCallback; 42 class RTCPeerConnectionErrorCallback;
43 class VoidCallback; 43 class VoidCallback;
44 44
45 class RTCVoidRequestImpl final : public RTCVoidRequest, 45 class RTCVoidRequestImpl final : public RTCVoidRequest,
46 public SuspendableObject { 46 public ContextLifecycleObserver {
47 USING_GARBAGE_COLLECTED_MIXIN(RTCVoidRequestImpl); 47 USING_GARBAGE_COLLECTED_MIXIN(RTCVoidRequestImpl);
48 48
49 public: 49 public:
50 static RTCVoidRequestImpl* create(ExecutionContext*, 50 static RTCVoidRequestImpl* create(ExecutionContext*,
51 RTCPeerConnection*, 51 RTCPeerConnection*,
52 VoidCallback*, 52 VoidCallback*,
53 RTCPeerConnectionErrorCallback*); 53 RTCPeerConnectionErrorCallback*);
54 ~RTCVoidRequestImpl() override; 54 ~RTCVoidRequestImpl() override;
55 55
56 // RTCVoidRequest 56 // RTCVoidRequest
57 void requestSucceeded() override; 57 void requestSucceeded() override;
58 void requestFailed(const String& error) override; 58 void requestFailed(const String& error) override;
59 59
60 // SuspendableObject 60 // ContextLifecycleObserver
61 void contextDestroyed() override; 61 void contextDestroyed() override;
62 62
63 DECLARE_VIRTUAL_TRACE(); 63 DECLARE_VIRTUAL_TRACE();
64 64
65 private: 65 private:
66 RTCVoidRequestImpl(ExecutionContext*, 66 RTCVoidRequestImpl(ExecutionContext*,
67 RTCPeerConnection*, 67 RTCPeerConnection*,
68 VoidCallback*, 68 VoidCallback*,
69 RTCPeerConnectionErrorCallback*); 69 RTCPeerConnectionErrorCallback*);
70 70
71 void clear(); 71 void clear();
72 72
73 Member<VoidCallback> m_successCallback; 73 Member<VoidCallback> m_successCallback;
74 Member<RTCPeerConnectionErrorCallback> m_errorCallback; 74 Member<RTCPeerConnectionErrorCallback> m_errorCallback;
75 Member<RTCPeerConnection> m_requester; 75 Member<RTCPeerConnection> m_requester;
76 }; 76 };
77 77
78 } // namespace blink 78 } // namespace blink
79 79
80 #endif // RTCVoidRequestImpl_h 80 #endif // RTCVoidRequestImpl_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698