Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: third_party/WebKit/Source/modules/peerconnection/RTCVoidRequestImpl.cpp

Issue 2583093002: Reduce SuspendableObjects (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 25 matching lines...) Expand all
36 #include "modules/peerconnection/RTCPeerConnection.h" 36 #include "modules/peerconnection/RTCPeerConnection.h"
37 #include "modules/peerconnection/RTCPeerConnectionErrorCallback.h" 37 #include "modules/peerconnection/RTCPeerConnectionErrorCallback.h"
38 38
39 namespace blink { 39 namespace blink {
40 40
41 RTCVoidRequestImpl* RTCVoidRequestImpl::create( 41 RTCVoidRequestImpl* RTCVoidRequestImpl::create(
42 ExecutionContext* context, 42 ExecutionContext* context,
43 RTCPeerConnection* requester, 43 RTCPeerConnection* requester,
44 VoidCallback* successCallback, 44 VoidCallback* successCallback,
45 RTCPeerConnectionErrorCallback* errorCallback) { 45 RTCPeerConnectionErrorCallback* errorCallback) {
46 RTCVoidRequestImpl* request = new RTCVoidRequestImpl( 46 return new RTCVoidRequestImpl(context, requester, successCallback,
47 context, requester, successCallback, errorCallback); 47 errorCallback);
48 request->suspendIfNeeded();
49 return request;
50 } 48 }
51 49
52 RTCVoidRequestImpl::RTCVoidRequestImpl( 50 RTCVoidRequestImpl::RTCVoidRequestImpl(
53 ExecutionContext* context, 51 ExecutionContext* context,
54 RTCPeerConnection* requester, 52 RTCPeerConnection* requester,
55 VoidCallback* successCallback, 53 VoidCallback* successCallback,
56 RTCPeerConnectionErrorCallback* errorCallback) 54 RTCPeerConnectionErrorCallback* errorCallback)
57 : SuspendableObject(context), 55 : ContextLifecycleObserver(context),
58 m_successCallback(successCallback), 56 m_successCallback(successCallback),
59 m_errorCallback(errorCallback), 57 m_errorCallback(errorCallback),
60 m_requester(requester) { 58 m_requester(requester) {
61 DCHECK(m_requester); 59 DCHECK(m_requester);
62 } 60 }
63 61
64 RTCVoidRequestImpl::~RTCVoidRequestImpl() {} 62 RTCVoidRequestImpl::~RTCVoidRequestImpl() {}
65 63
66 void RTCVoidRequestImpl::requestSucceeded() { 64 void RTCVoidRequestImpl::requestSucceeded() {
67 bool shouldFireCallback = 65 bool shouldFireCallback =
(...skipping 24 matching lines...) Expand all
92 m_successCallback.clear(); 90 m_successCallback.clear();
93 m_errorCallback.clear(); 91 m_errorCallback.clear();
94 m_requester.clear(); 92 m_requester.clear();
95 } 93 }
96 94
97 DEFINE_TRACE(RTCVoidRequestImpl) { 95 DEFINE_TRACE(RTCVoidRequestImpl) {
98 visitor->trace(m_successCallback); 96 visitor->trace(m_successCallback);
99 visitor->trace(m_errorCallback); 97 visitor->trace(m_errorCallback);
100 visitor->trace(m_requester); 98 visitor->trace(m_requester);
101 RTCVoidRequest::trace(visitor); 99 RTCVoidRequest::trace(visitor);
102 SuspendableObject::trace(visitor); 100 ContextLifecycleObserver::trace(visitor);
103 } 101 }
104 102
105 } // namespace blink 103 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698