Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: third_party/WebKit/Source/core/animation/Animation.cpp

Issue 2583093002: Reduce SuspendableObjects (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/animation/Animation.h ('k') | third_party/WebKit/Source/core/css/FontFace.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/animation/Animation.cpp
diff --git a/third_party/WebKit/Source/core/animation/Animation.cpp b/third_party/WebKit/Source/core/animation/Animation.cpp
index 8799d30bf98368fe8eebbd7b05d5cafa7879112c..0aaf5959a9567417f165d6aafd749185035fea86 100644
--- a/third_party/WebKit/Source/core/animation/Animation.cpp
+++ b/third_party/WebKit/Source/core/animation/Animation.cpp
@@ -68,7 +68,6 @@ Animation* Animation::create(AnimationEffectReadOnly* effect,
Animation* animation =
new Animation(timeline->document()->contextDocument(), *timeline, effect);
- animation->suspendIfNeeded();
if (timeline) {
timeline->animationAttached(*animation);
@@ -81,7 +80,7 @@ Animation* Animation::create(AnimationEffectReadOnly* effect,
Animation::Animation(ExecutionContext* executionContext,
AnimationTimeline& timeline,
AnimationEffectReadOnly* content)
- : SuspendableObject(executionContext),
+ : ContextLifecycleObserver(executionContext),
m_playState(Idle),
m_playbackRate(1),
m_startTime(nullValue()),
@@ -646,7 +645,7 @@ const AtomicString& Animation::interfaceName() const {
}
ExecutionContext* Animation::getExecutionContext() const {
- return SuspendableObject::getExecutionContext();
+ return ContextLifecycleObserver::getExecutionContext();
}
bool Animation::hasPendingActivity() const {
@@ -1119,7 +1118,7 @@ DEFINE_TRACE(Animation) {
visitor->trace(m_readyPromise);
visitor->trace(m_compositorPlayer);
EventTargetWithInlineData::trace(visitor);
- SuspendableObject::trace(visitor);
+ ContextLifecycleObserver::trace(visitor);
}
Animation::CompositorAnimationPlayerHolder*
« no previous file with comments | « third_party/WebKit/Source/core/animation/Animation.h ('k') | third_party/WebKit/Source/core/css/FontFace.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698