Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Unified Diff: third_party/WebKit/Source/modules/peerconnection/RTCVoidRequestImpl.cpp

Issue 2583093002: Reduce SuspendableObjects (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/peerconnection/RTCVoidRequestImpl.cpp
diff --git a/third_party/WebKit/Source/modules/peerconnection/RTCVoidRequestImpl.cpp b/third_party/WebKit/Source/modules/peerconnection/RTCVoidRequestImpl.cpp
index 26b74db1224560dfa58fad07173d5510767d1900..7daa2c5793005a0699be842b6e0aff7ff827f6de 100644
--- a/third_party/WebKit/Source/modules/peerconnection/RTCVoidRequestImpl.cpp
+++ b/third_party/WebKit/Source/modules/peerconnection/RTCVoidRequestImpl.cpp
@@ -43,10 +43,8 @@ RTCVoidRequestImpl* RTCVoidRequestImpl::create(
RTCPeerConnection* requester,
VoidCallback* successCallback,
RTCPeerConnectionErrorCallback* errorCallback) {
- RTCVoidRequestImpl* request = new RTCVoidRequestImpl(
- context, requester, successCallback, errorCallback);
- request->suspendIfNeeded();
- return request;
+ return new RTCVoidRequestImpl(context, requester, successCallback,
+ errorCallback);
}
RTCVoidRequestImpl::RTCVoidRequestImpl(
@@ -54,7 +52,7 @@ RTCVoidRequestImpl::RTCVoidRequestImpl(
RTCPeerConnection* requester,
VoidCallback* successCallback,
RTCPeerConnectionErrorCallback* errorCallback)
- : SuspendableObject(context),
+ : ContextLifecycleObserver(context),
m_successCallback(successCallback),
m_errorCallback(errorCallback),
m_requester(requester) {
@@ -99,7 +97,7 @@ DEFINE_TRACE(RTCVoidRequestImpl) {
visitor->trace(m_errorCallback);
visitor->trace(m_requester);
RTCVoidRequest::trace(visitor);
- SuspendableObject::trace(visitor);
+ ContextLifecycleObserver::trace(visitor);
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698