Reduce SuspendableObjects

third_party/WebKit/Source/modules/eventsource/EventSource.h

 /*
  * Copyright (C) 2009, 2012 Ericsson AB. All rights reserved.
  * Copyright (C) 2010 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
@@ skipping 15 matching lines @@
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef EventSource_h
 #define EventSource_h
 
 #include "bindings/core/v8/ActiveScriptWrappable.h"
-#include "core/dom/SuspendableObject.h"
+#include "core/dom/ContextLifecycleObserver.h"
 #include "core/events/EventTarget.h"
 #include "core/loader/ThreadableLoader.h"
 #include "core/loader/ThreadableLoaderClient.h"
 #include "modules/ModulesExport.h"
 #include "modules/eventsource/EventSourceParser.h"
 #include "platform/Timer.h"
 #include "platform/heap/Handle.h"
 #include "platform/weborigin/KURL.h"
 #include "wtf/Forward.h"
 #include <memory>
 
 namespace blink {
 
 class EventSourceInit;
 class ExceptionState;
 class ResourceResponse;
 
 class MODULES_EXPORT EventSource final
     : public EventTargetWithInlineData,
       private ThreadableLoaderClient,
       public ActiveScriptWrappable<EventSource>,
-      public SuspendableObject,
+      public ContextLifecycleObserver,
       public EventSourceParser::Client {
   DEFINE_WRAPPERTYPEINFO();
   USING_GARBAGE_COLLECTED_MIXIN(EventSource);
 
  public:
   static EventSource* create(ExecutionContext*,
                              const String& url,
                              const EventSourceInit&,
                              ExceptionState&);
   ~EventSource() override;
 
   static const unsigned long long defaultReconnectDelay;
 
   String url() const;
   bool withCredentials() const;
 
   enum State : short { kConnecting = 0, kOpen = 1, kClosed = 2 };
 
   State readyState() const;
 
   DEFINE_ATTRIBUTE_EVENT_LISTENER(open);
   DEFINE_ATTRIBUTE_EVENT_LISTENER(message);
   DEFINE_ATTRIBUTE_EVENT_LISTENER(error);
 
   void close();
 
   const AtomicString& interfaceName() const override;
   ExecutionContext* getExecutionContext() const override;
 
-  // SuspendableObject
+  // ContextLifecycleObserver
   //
-  // Note: suspend() is noop since ScopedPageLoadDeferrer calls
-  // Page::setDefersLoading() and it defers delivery of events from the
-  // loader, and therefore the methods of this class for receiving
-  // asynchronous events from the loader won't be invoked.
+  // Note: We don't need to inherit from SuspendableObject since
+  // ScopedPageLoadDeferrer calls Page::setDefersLoading() and
+  // it defers delivery of events from the loader, and therefore
+  // the methods of this class for receiving asynchronous events
+  // from the loader won't be invoked.
   void contextDestroyed() override;
 
   // ScriptWrappable
   bool hasPendingActivity() const final;
 
   DECLARE_VIRTUAL_TRACE();
 
  private:
   EventSource(ExecutionContext*, const KURL&, const EventSourceInit&);
 
@@ skipping 31 matching lines @@
   Member<ThreadableLoader> m_loader;
   Timer<EventSource> m_connectTimer;
 
   unsigned long long m_reconnectDelay;
   String m_eventStreamOrigin;
 };
 
 }  // namespace blink
 
 #endif  // EventSource_h