Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp

Issue 2583093002: Reduce SuspendableObjects (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp
diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp b/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp
index 9105f59c6d861b55ef602defd6184bdc95f36672..da44d0a7d36c95f841dbe5eb658caf3c8f34d096 100644
--- a/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp
+++ b/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp
@@ -92,16 +92,13 @@ const char IDBDatabase::databaseClosedErrorMessage[] =
IDBDatabase* IDBDatabase::create(ExecutionContext* context,
std::unique_ptr<WebIDBDatabase> database,
IDBDatabaseCallbacks* callbacks) {
- IDBDatabase* idbDatabase =
- new IDBDatabase(context, std::move(database), callbacks);
- idbDatabase->suspendIfNeeded();
- return idbDatabase;
+ return new IDBDatabase(context, std::move(database), callbacks);
}
IDBDatabase::IDBDatabase(ExecutionContext* context,
std::unique_ptr<WebIDBDatabase> backend,
IDBDatabaseCallbacks* callbacks)
- : SuspendableObject(context),
+ : ContextLifecycleObserver(context),
m_backend(std::move(backend)),
m_databaseCallbacks(callbacks) {
m_databaseCallbacks->connect(this);
@@ -119,7 +116,7 @@ DEFINE_TRACE(IDBDatabase) {
visitor->trace(m_enqueuedEvents);
visitor->trace(m_databaseCallbacks);
EventTargetWithInlineData::trace(visitor);
- SuspendableObject::trace(visitor);
+ ContextLifecycleObserver::trace(visitor);
}
int64_t IDBDatabase::nextTransactionId() {
@@ -578,7 +575,7 @@ const AtomicString& IDBDatabase::interfaceName() const {
}
ExecutionContext* IDBDatabase::getExecutionContext() const {
- return SuspendableObject::getExecutionContext();
+ return ContextLifecycleObserver::getExecutionContext();
}
void IDBDatabase::recordApiCallsHistogram(IndexedDatabaseMethods method) {

Powered by Google App Engine
This is Rietveld 408576698