Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h

Issue 2583093002: Reduce SuspendableObjects (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h
diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h
index de12e93bddbc103a75f761614f8a9e0fd0ee839f..e4cd79e652a8656111e5676e22ed8635839cf14a 100644
--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h
+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h
@@ -7,7 +7,7 @@
#include "bindings/core/v8/ActiveScriptWrappable.h"
#include "bindings/core/v8/ScriptPromiseResolver.h"
-#include "core/dom/SuspendableObject.h"
+#include "core/dom/ContextLifecycleObserver.h"
#include "core/events/EventTarget.h"
#include "modules/serviceworkers/NavigationPreloadManager.h"
#include "modules/serviceworkers/ServiceWorker.h"
@@ -29,7 +29,7 @@ class ScriptState;
class ServiceWorkerRegistration final
: public EventTargetWithInlineData,
public ActiveScriptWrappable<ServiceWorkerRegistration>,
- public SuspendableObject,
+ public ContextLifecycleObserver,
public WebServiceWorkerRegistrationProxy,
public Supplementable<ServiceWorkerRegistration> {
DEFINE_WRAPPERTYPEINFO();
@@ -49,7 +49,7 @@ class ServiceWorkerRegistration final
// EventTarget overrides.
const AtomicString& interfaceName() const override;
ExecutionContext* getExecutionContext() const override {
- return SuspendableObject::getExecutionContext();
+ return ContextLifecycleObserver::getExecutionContext();
}
// WebServiceWorkerRegistrationProxy overrides.
@@ -90,7 +90,7 @@ class ServiceWorkerRegistration final
std::unique_ptr<WebServiceWorkerRegistration::Handle>);
void dispose();
- // SuspendableObject overrides.
+ // ContextLifecycleObserver overrides.
void contextDestroyed() override;
// A handle to the registration representation in the embedder.

Powered by Google App Engine
This is Rietveld 408576698