Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Unified Diff: third_party/WebKit/Source/modules/peerconnection/RTCSessionDescriptionRequestImpl.cpp

Issue 2583093002: Reduce SuspendableObjects (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/peerconnection/RTCSessionDescriptionRequestImpl.cpp
diff --git a/third_party/WebKit/Source/modules/peerconnection/RTCSessionDescriptionRequestImpl.cpp b/third_party/WebKit/Source/modules/peerconnection/RTCSessionDescriptionRequestImpl.cpp
index 1526fa422343fcc1430157c875057b35b81ec049..8548aada571ec84447ceceab0d5eb40bb21207c1 100644
--- a/third_party/WebKit/Source/modules/peerconnection/RTCSessionDescriptionRequestImpl.cpp
+++ b/third_party/WebKit/Source/modules/peerconnection/RTCSessionDescriptionRequestImpl.cpp
@@ -46,11 +46,8 @@ RTCSessionDescriptionRequestImpl* RTCSessionDescriptionRequestImpl::create(
RTCPeerConnection* requester,
RTCSessionDescriptionCallback* successCallback,
RTCPeerConnectionErrorCallback* errorCallback) {
- RTCSessionDescriptionRequestImpl* request =
- new RTCSessionDescriptionRequestImpl(context, requester, successCallback,
- errorCallback);
- request->suspendIfNeeded();
- return request;
+ return new RTCSessionDescriptionRequestImpl(context, requester,
+ successCallback, errorCallback);
}
RTCSessionDescriptionRequestImpl::RTCSessionDescriptionRequestImpl(
@@ -58,7 +55,7 @@ RTCSessionDescriptionRequestImpl::RTCSessionDescriptionRequestImpl(
RTCPeerConnection* requester,
RTCSessionDescriptionCallback* successCallback,
RTCPeerConnectionErrorCallback* errorCallback)
- : SuspendableObject(context),
+ : ContextLifecycleObserver(context),
m_successCallback(successCallback),
m_errorCallback(errorCallback),
m_requester(requester) {
@@ -101,7 +98,7 @@ DEFINE_TRACE(RTCSessionDescriptionRequestImpl) {
visitor->trace(m_errorCallback);
visitor->trace(m_requester);
RTCSessionDescriptionRequest::trace(visitor);
- SuspendableObject::trace(visitor);
+ ContextLifecycleObserver::trace(visitor);
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698