Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: third_party/WebKit/Source/modules/notifications/Notification.h

Issue 2583093002: Reduce SuspendableObjects (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/notifications/Notification.h
diff --git a/third_party/WebKit/Source/modules/notifications/Notification.h b/third_party/WebKit/Source/modules/notifications/Notification.h
index ca77ae49e0fbfc95ff7998ad67667e03200dc2c4..acdfd9205f2dde25fb16754f3b421275e94e8d6e 100644
--- a/third_party/WebKit/Source/modules/notifications/Notification.h
+++ b/third_party/WebKit/Source/modules/notifications/Notification.h
@@ -35,8 +35,8 @@
#include "bindings/core/v8/ScriptPromise.h"
#include "bindings/core/v8/ScriptValue.h"
#include "bindings/core/v8/SerializedScriptValue.h"
+#include "core/dom/ContextLifecycleObserver.h"
#include "core/dom/DOMTimeStamp.h"
-#include "core/dom/SuspendableObject.h"
#include "modules/EventTargetModules.h"
#include "modules/ModulesExport.h"
#include "modules/vibration/NavigatorVibration.h"
@@ -60,7 +60,7 @@ class ScriptState;
class MODULES_EXPORT Notification final
: public EventTargetWithInlineData,
public ActiveScriptWrappable<Notification>,
- public SuspendableObject,
+ public ContextLifecycleObserver,
public WebNotificationDelegate {
USING_GARBAGE_COLLECTED_MIXIN(Notification);
DEFINE_WRAPPERTYPEINFO();
@@ -121,11 +121,11 @@ class MODULES_EXPORT Notification final
// EventTarget interface.
ExecutionContext* getExecutionContext() const final {
- return SuspendableObject::getExecutionContext();
+ return ContextLifecycleObserver::getExecutionContext();
}
const AtomicString& interfaceName() const override;
- // SuspendableObject interface.
+ // ContextLifecycleObserver interface.
void contextDestroyed() override;
// ScriptWrappable interface.

Powered by Google App Engine
This is Rietveld 408576698