Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: third_party/WebKit/Source/modules/peerconnection/RTCDTMFSender.cpp

Issue 2583093002: Reduce SuspendableObjects (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/peerconnection/RTCDTMFSender.cpp
diff --git a/third_party/WebKit/Source/modules/peerconnection/RTCDTMFSender.cpp b/third_party/WebKit/Source/modules/peerconnection/RTCDTMFSender.cpp
index 7deedaf434440e4a8813660369878e9d983d7fcd..36a21afd6c9195c2db890a55627fb2d6c015b1fc 100644
--- a/third_party/WebKit/Source/modules/peerconnection/RTCDTMFSender.cpp
+++ b/third_party/WebKit/Source/modules/peerconnection/RTCDTMFSender.cpp
@@ -60,16 +60,13 @@ RTCDTMFSender* RTCDTMFSender::create(
return nullptr;
}
- RTCDTMFSender* dtmfSender =
- new RTCDTMFSender(context, track, std::move(handler));
- dtmfSender->suspendIfNeeded();
- return dtmfSender;
+ return new RTCDTMFSender(context, track, std::move(handler));
}
RTCDTMFSender::RTCDTMFSender(ExecutionContext* context,
MediaStreamTrack* track,
std::unique_ptr<WebRTCDTMFSenderHandler> handler)
- : SuspendableObject(context),
+ : ContextLifecycleObserver(context),
m_track(track),
m_duration(defaultToneDurationMs),
m_interToneGap(defaultInterToneGapMs),
@@ -156,7 +153,7 @@ const AtomicString& RTCDTMFSender::interfaceName() const {
}
ExecutionContext* RTCDTMFSender::getExecutionContext() const {
- return SuspendableObject::getExecutionContext();
+ return ContextLifecycleObserver::getExecutionContext();
}
void RTCDTMFSender::contextDestroyed() {
@@ -187,7 +184,7 @@ DEFINE_TRACE(RTCDTMFSender) {
visitor->trace(m_track);
visitor->trace(m_scheduledEvents);
EventTargetWithInlineData::trace(visitor);
- SuspendableObject::trace(visitor);
+ ContextLifecycleObserver::trace(visitor);
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698