Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(842)

Unified Diff: third_party/WebKit/Source/modules/webmidi/MIDIAccess.h

Issue 2583093002: Reduce SuspendableObjects (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webmidi/MIDIAccess.h
diff --git a/third_party/WebKit/Source/modules/webmidi/MIDIAccess.h b/third_party/WebKit/Source/modules/webmidi/MIDIAccess.h
index e0c3e884262eaf1334bbcbc5d3b3f4e2d492bd3d..8b23ad510093b6d3a00400df059d636b6df34ff4 100644
--- a/third_party/WebKit/Source/modules/webmidi/MIDIAccess.h
+++ b/third_party/WebKit/Source/modules/webmidi/MIDIAccess.h
@@ -33,7 +33,7 @@
#include "bindings/core/v8/ActiveScriptWrappable.h"
#include "bindings/core/v8/ScriptPromise.h"
-#include "core/dom/SuspendableObject.h"
+#include "core/dom/ContextLifecycleObserver.h"
#include "media/midi/midi_service.mojom-blink.h"
#include "modules/EventTargetModules.h"
#include "modules/webmidi/MIDIAccessInitializer.h"
@@ -53,7 +53,7 @@ class MIDIOutputMap;
class MIDIAccess final : public EventTargetWithInlineData,
public ActiveScriptWrappable<MIDIAccess>,
- public SuspendableObject,
+ public ContextLifecycleObserver,
public MIDIAccessorClient {
DEFINE_WRAPPERTYPEINFO();
USING_GARBAGE_COLLECTED_MIXIN(MIDIAccess);
@@ -65,10 +65,8 @@ class MIDIAccess final : public EventTargetWithInlineData,
bool sysexEnabled,
const Vector<MIDIAccessInitializer::PortDescriptor>& ports,
ExecutionContext* executionContext) {
- MIDIAccess* access = new MIDIAccess(std::move(accessor), sysexEnabled,
- ports, executionContext);
- access->suspendIfNeeded();
- return access;
+ return new MIDIAccess(std::move(accessor), sysexEnabled, ports,
+ executionContext);
}
~MIDIAccess() override;
@@ -85,13 +83,13 @@ class MIDIAccess final : public EventTargetWithInlineData,
return EventTargetNames::MIDIAccess;
}
ExecutionContext* getExecutionContext() const override {
- return SuspendableObject::getExecutionContext();
+ return ContextLifecycleObserver::getExecutionContext();
}
// ScriptWrappable
bool hasPendingActivity() const final;
- // SuspendableObject
+ // ContextLifecycleObserver
void contextDestroyed() override;
// MIDIAccessorClient

Powered by Google App Engine
This is Rietveld 408576698