Call preventDefault in all on-tap events that show a dialog.

Call preventDefault in all on-tap events that show a dialog.

BUG=653415
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/6083648a5b1e07dbda893e897d574e28292aff6d
Cr-Commit-Position: refs/heads/master@{#437374}

[hcarmona, 2016-12-07 16:23:20]

Description was changed from

==========
Call |preventDefault| in all |on-tap| events that show a dialog.

BUG=653415
==========

to

==========
Call |preventDefault| in all |on-tap| events that show a dialog.

BUG=653415
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[hcarmona, 2016-12-07 16:23:22]

The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 16:23:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 16:41:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 16:41:11]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[hcarmona, 2016-12-07 18:15:36]

The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 18:16:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2016-12-07 18:17:06]

https://codereview.chromium.org/2557073003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/people_page/people_page.js (right):

https://codereview.chromium.org/2557073003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/people_page.js:339: * @param
{Event} e The polymer event.
Nit: !Event here and elsewhere.

[hcarmona, 2016-12-07 18:41:08]

The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 18:41:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hcarmona, 2016-12-07 18:51:08]

The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 18:51:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hcarmona, 2016-12-07 18:51:27]

Patchset #3 (id:40001) has been deleted

[hcarmona, 2016-12-07 18:52:18]

hcarmona@chromium.org changed reviewers:
+ dpapad@chromium.org

[hcarmona, 2016-12-07 18:52:19]

PTAL

https://codereview.chromium.org/2557073003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/people_page/people_page.js (right):

https://codereview.chromium.org/2557073003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/people_page.js:339: * @param
{Event} e The polymer event.
On 2016/12/07 18:17:06, dpapad wrote:
> Nit: !Event here and elsewhere.

Done.

[dpapad, 2016-12-07 20:00:50]

LGTM. Perhaps remove "|" characters from the CL description? I've seen them
being used in code comments, but not in a CL description before.

https://codereview.chromium.org/2557073003/diff/60001/chrome/browser/resource...
File chrome/browser/resources/settings/about_page/detailed_build_info.js
(right):

https://codereview.chromium.org/2557073003/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/about_page/detailed_build_info.js:59: * @param
{!Event} e The polymer event.
Nit (optional): Perhaps drop the "The polymer event" comment from everywhere
since it does not add much useful info.

[commit-bot: I haz the power, 2016-12-07 20:38:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 20:38:03]

Dry run: This issue passed the CQ dry run.

[hcarmona, 2016-12-08 20:09:49]

The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run

[hcarmona, 2016-12-08 20:09:51]

Description was changed from

==========
Call |preventDefault| in all |on-tap| events that show a dialog.

BUG=653415
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Call preventDefault in all on-tap events that show a dialog.

BUG=653415
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-12-08 20:10:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hcarmona, 2016-12-08 20:12:50]

Fixed nit and updated description.

https://codereview.chromium.org/2557073003/diff/60001/chrome/browser/resource...
File chrome/browser/resources/settings/about_page/detailed_build_info.js
(right):

https://codereview.chromium.org/2557073003/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/about_page/detailed_build_info.js:59: * @param
{!Event} e The polymer event.
On 2016/12/07 20:00:50, dpapad wrote:
> Nit (optional): Perhaps drop the "The polymer event" comment from everywhere
> since it does not add much useful info.

Done.

[hcarmona, 2016-12-08 20:13:00]

The CQ bit was unchecked by hcarmona@chromium.org

[hcarmona, 2016-12-08 20:13:00]

The CQ bit was checked by hcarmona@chromium.org

[hcarmona, 2016-12-08 20:13:00]

The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2557073003/#ps80001
(title: "nit")

[commit-bot: I haz the power, 2016-12-08 20:13:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 22:42:10]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1481227980290690,
"parent_rev": "017b72c3879e1b3e1af6d10f235dda3921e5e9c3", "commit_rev":
"cd54c85cc191ede1859fbcb9a4136ff2a24219c6"}

[commit-bot: I haz the power, 2016-12-08 22:42:36]

Description was changed from

==========
Call preventDefault in all on-tap events that show a dialog.

BUG=653415
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Call preventDefault in all on-tap events that show a dialog.

BUG=653415
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-12-08 22:42:37]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-12-08 22:46:34]

Description was changed from

==========
Call preventDefault in all on-tap events that show a dialog.

BUG=653415
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Call preventDefault in all on-tap events that show a dialog.

BUG=653415
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/6083648a5b1e07dbda893e897d574e28292aff6d
Cr-Commit-Position: refs/heads/master@{#437374}
==========

[commit-bot: I haz the power, 2016-12-08 22:46:35]

Patchset 4 (id:??) landed as
https://crrev.com/6083648a5b1e07dbda893e897d574e28292aff6d
Cr-Commit-Position: refs/heads/master@{#437374}