chrome/browser/resources/settings/about_page/detailed_build_info.js - Issue 2557073003: Call preventDefault in all on-tap events that show a dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/about_page/detailed_build_info.js

Issue 2557073003: Call preventDefault in all on-tap events that show a dialog. (Closed)

Patch Set: nit Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/settings/about_page/detailed_build_info.js

diff --git a/chrome/browser/resources/settings/about_page/detailed_build_info.js b/chrome/browser/resources/settings/about_page/detailed_build_info.js

index ab301700ec3036ca490badaaf5987f80ffab750f..e408dafdff62809317f0213d3dfa2147d6ef3a9e 100644

--- a/chrome/browser/resources/settings/about_page/detailed_build_info.js

+++ b/chrome/browser/resources/settings/about_page/detailed_build_info.js

@@ -55,8 +55,12 @@ Polymer({

return version.length > 0;

- /** @private */

- onChangeChannelTap_: function() {

+ /**

+ * @param {!Event} e

+ * @private

+ */

+ onChangeChannelTap_: function(e) {

+ e.preventDefault();

this.showChannelSwitcherDialog_ = true;

// Async to wait for dialog to appear in the DOM.

this.async(function() {

« no previous file with comments | « no previous file | chrome/browser/resources/settings/bluetooth_page/bluetooth_page.js » ('j') | no next file with comments »