Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3622)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/settings/people_page/lock_screen.js

Issue 2557073003: Call preventDefault in all on-tap events that show a dialog. (Closed)
Patch Set: nit Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.js ('k') | chrome/browser/resources/settings/people_page/people_page.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/people_page/lock_screen.js
diff --git a/chrome/browser/resources/settings/people_page/lock_screen.js b/chrome/browser/resources/settings/people_page/lock_screen.js
index f296363be34d22c6969668a110d742ddcf0a9617..762bd2cb8a426c762e429159415f752e82664d04 100644
--- a/chrome/browser/resources/settings/people_page/lock_screen.js
+++ b/chrome/browser/resources/settings/people_page/lock_screen.js
@@ -118,8 +118,12 @@ Polymer({
return this.i18n('lockScreenSetupPinButton');
},
- /** @private */
- onConfigurePin_: function() {
+ /**
+ * @param {!Event} e
+ * @private
+ */
+ onConfigurePin_: function(e) {
+ e.preventDefault();
this.$.setupPin.open();
},
});
« no previous file with comments | « chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.js ('k') | chrome/browser/resources/settings/people_page/people_page.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698