Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2998)

Unified Diff: chrome/browser/resources/settings/reset_page/reset_page.js

Issue 2557073003: Call preventDefault in all on-tap events that show a dialog. (Closed)
Patch Set: nit Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/reset_page/reset_page.js
diff --git a/chrome/browser/resources/settings/reset_page/reset_page.js b/chrome/browser/resources/settings/reset_page/reset_page.js
index dc69d704721204c2393260d0e5c799ae1dd19a61..e5c5112a603e269319ea7f814bdea77ae0e9400d 100644
--- a/chrome/browser/resources/settings/reset_page/reset_page.js
+++ b/chrome/browser/resources/settings/reset_page/reset_page.js
@@ -62,8 +62,12 @@ Polymer({
},
<if expr="chromeos">
- /** @private */
- onShowPowerwashDialog_: function() {
+ /**
+ * @param {!Event} e
+ * @private
+ */
+ onShowPowerwashDialog_: function(e) {
+ e.preventDefault();
this.showPowerwashDialog_ = true;
},

Powered by Google App Engine
This is Rietveld 408576698