Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: chrome/browser/resources/settings/languages_page/languages_page.js

Issue 2557073003: Call preventDefault in all on-tap events that show a dialog. (Closed)
Patch Set: nit Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/languages_page/languages_page.js
diff --git a/chrome/browser/resources/settings/languages_page/languages_page.js b/chrome/browser/resources/settings/languages_page/languages_page.js
index 176135ddee39abc4eb272e7c70b04725232763f5..10309a3914834a77d87e6466b2dbaddb6c6469df 100644
--- a/chrome/browser/resources/settings/languages_page/languages_page.js
+++ b/chrome/browser/resources/settings/languages_page/languages_page.js
@@ -68,9 +68,11 @@ Polymer({
/**
* Stamps and opens the Add Languages dialog, registering a listener to
* disable the dialog's dom-if again on close.
+ * @param {!Event} e
* @private
*/
- onAddLanguagesTap_: function() {
+ onAddLanguagesTap_: function(e) {
+ e.preventDefault();
this.showAddLanguagesDialog_ = true;
this.async(function() {
var dialog = this.$$('settings-add-languages-dialog');

Powered by Google App Engine
This is Rietveld 408576698