chrome/browser/resources/settings/search_engines_page/search_engines_page.js - Issue 2557073003: Call preventDefault in all on-tap events that show a dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/search_engines_page/search_engines_page.js

Issue 2557073003: Call preventDefault in all on-tap events that show a dialog. (Closed)

Patch Set: nit Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/search_engines_page/search_engine_entry.js ('k') | chrome/browser/resources/settings/site_settings/site_data.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/search_engines_page/search_engines_page.js

diff --git a/chrome/browser/resources/settings/search_engines_page/search_engines_page.js b/chrome/browser/resources/settings/search_engines_page/search_engines_page.js

index 4273c8717ea0d1c1bc316ca406275f01159bf928..a9379bfc6f1d5d9604cad96c940ad65f5a2e00ed 100644

--- a/chrome/browser/resources/settings/search_engines_page/search_engines_page.js

+++ b/chrome/browser/resources/settings/search_engines_page/search_engines_page.js

@@ -68,8 +68,12 @@ Polymer({

this.extensions = searchEnginesInfo['extensions'];

- /** @private */

- onAddSearchEngineTap_: function() {

+ /**

+ * @param {!Event} e

+ * @private

+ */

+ onAddSearchEngineTap_: function(e) {

+ e.preventDefault();

this.showAddSearchEngineDialog_ = true;

this.async(function() {

var dialog = this.$$('settings-search-engine-dialog');