chrome/browser/resources/settings/on_startup_page/startup_url_entry.js - Issue 2557073003: Call preventDefault in all on-tap events that show a dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/on_startup_page/startup_url_entry.js

Issue 2557073003: Call preventDefault in all on-tap events that show a dialog. (Closed)

Patch Set: nit Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/languages_page/languages_page.js ('k') | chrome/browser/resources/settings/on_startup_page/startup_urls_page.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/on_startup_page/startup_url_entry.js

diff --git a/chrome/browser/resources/settings/on_startup_page/startup_url_entry.js b/chrome/browser/resources/settings/on_startup_page/startup_url_entry.js

index b5d363e47b21f1a153c1d241d602689d1ff14887..27de5f0e600f7613550b979de8598a5ddb3d29b9 100644

--- a/chrome/browser/resources/settings/on_startup_page/startup_url_entry.js

+++ b/chrome/browser/resources/settings/on_startup_page/startup_url_entry.js

@@ -46,8 +46,12 @@ Polymer({

this.model.modelIndex);

- /** @private */

- onEditTap_: function() {

+ /**

+ * @param {!Event} e

+ * @private

+ */

+ onEditTap_: function(e) {

+ e.preventDefault();

this.$$('dialog[is=cr-action-menu]').close();

this.fire(settings.EDIT_STARTUP_URL_EVENT, this.model);