chrome/browser/resources/settings/device_page/storage.js - Issue 2557073003: Call preventDefault in all on-tap events that show a dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/device_page/storage.js

Issue 2557073003: Call preventDefault in all on-tap events that show a dialog. (Closed)

Patch Set: nit Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/settings/device_page/storage.js

diff --git a/chrome/browser/resources/settings/device_page/storage.js b/chrome/browser/resources/settings/device_page/storage.js

index b37149467108630208945fae27b8e45e8c63407f..b10445da3f3c7a127efe7284ee485b5aa05874ab 100644

--- a/chrome/browser/resources/settings/device_page/storage.js

+++ b/chrome/browser/resources/settings/device_page/storage.js

@@ -115,9 +115,11 @@ Polymer({

/**

* Handler for tapping the "Offline files" item.

+ * @param {!Event} e

* @private

- onDriveCacheTap_: function() {

+ onDriveCacheTap_: function(e) {

+ e.preventDefault();

this.$.storageDriveCache.open();