chrome/browser/resources/settings/reset_page/reset_profile_banner.js - Issue 2557073003: Call preventDefault in all on-tap events that show a dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/reset_page/reset_profile_banner.js

Issue 2557073003: Call preventDefault in all on-tap events that show a dialog. (Closed)

Patch Set: nit Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/reset_page/reset_page.js ('k') | chrome/browser/resources/settings/search_engines_page/search_engine_entry.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/reset_page/reset_profile_banner.js

diff --git a/chrome/browser/resources/settings/reset_page/reset_profile_banner.js b/chrome/browser/resources/settings/reset_page/reset_profile_banner.js

index 4ce02ea192b98643e2757ea6d500d4bc1d1da988..758582f22738753530d351af8ea28b56687717f1 100644

--- a/chrome/browser/resources/settings/reset_page/reset_profile_banner.js

+++ b/chrome/browser/resources/settings/reset_page/reset_profile_banner.js

@@ -25,9 +25,11 @@ Polymer({

/**

* Shows a <settings-reset-profile-dialog>.

+ * @param {!Event} e

* @private

- showDialog_: function() {

+ showDialog_: function(e) {

+ e.preventDefault();

this.showResetProfileDialog_ = true;