Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1512)

Unified Diff: chrome/browser/resources/settings/site_settings/site_data.js

Issue 2557073003: Call preventDefault in all on-tap events that show a dialog. (Closed)
Patch Set: nit Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/site_settings/site_data.js
diff --git a/chrome/browser/resources/settings/site_settings/site_data.js b/chrome/browser/resources/settings/site_settings/site_data.js
index c5df0d69c512672b5fb55d271b8efc7cc30b31ef..ab87956c66256e9e918dbc3ba5a8ea3af5472d7f 100644
--- a/chrome/browser/resources/settings/site_settings/site_data.js
+++ b/chrome/browser/resources/settings/site_settings/site_data.js
@@ -75,9 +75,11 @@ Polymer({
/**
* Shows a dialog to confirm the deletion of multiple sites.
+ * @param {!Event} e
* @private
*/
- onConfirmDeleteMultipleSites_: function() {
+ onConfirmDeleteMultipleSites_: function(e) {
+ e.preventDefault();
this.idToDelete_ = ''; // Delete all.
this.confirmationDeleteMsg_ = loadTimeData.getString(
'siteSettingsCookieRemoveMultipleConfirmation');

Powered by Google App Engine
This is Rietveld 408576698