chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js - Issue 2557073003: Call preventDefault in all on-tap events that show a dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js

Issue 2557073003: Call preventDefault in all on-tap events that show a dialog. (Closed)

Patch Set: nit Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/on_startup_page/startup_urls_page.js ('k') | chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js

diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js

index 51377c74ef3ea10e21852210e4c031a5f19f4076..32fea6ec1aca68acee5af3d5a8370b2f01ec4478 100644

--- a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js

+++ b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js

@@ -92,9 +92,11 @@ Polymer({

/**

* Shows the edit password dialog.

+ * @param {!Event} e

* @private

- onMenuEditPasswordTap_: function() {

+ onMenuEditPasswordTap_: function(e) {

+ e.preventDefault();

/** @type {CrActionMenuElement} */(this.$.menu).close();

this.showPasswordEditDialog_ = true;