Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3213)

Unified Diff: chrome/browser/resources/settings/site_settings/site_list.js

Issue 2557073003: Call preventDefault in all on-tap events that show a dialog. (Closed)
Patch Set: nit Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/site_settings/site_details.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/site_settings/site_list.js
diff --git a/chrome/browser/resources/settings/site_settings/site_list.js b/chrome/browser/resources/settings/site_settings/site_list.js
index d121b5bedbfc14756f56fe83496114658963596f..188cb67c13b40abb04953f160684c302ade108d2 100644
--- a/chrome/browser/resources/settings/site_settings/site_list.js
+++ b/chrome/browser/resources/settings/site_settings/site_list.js
@@ -217,9 +217,11 @@ Polymer({
/**
* A handler for the Add Site button.
+ * @param {!Event} e
* @private
*/
- onAddSiteTap_: function() {
+ onAddSiteTap_: function(e) {
+ e.preventDefault();
var dialog = document.createElement('add-site-dialog');
dialog.category = this.category;
dialog.contentSetting = this.categorySubtype;
« no previous file with comments | « chrome/browser/resources/settings/site_settings/site_details.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698