Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1002)

Unified Diff: chrome/browser/resources/settings/internet_page/network_siminfo.js

Issue 2557073003: Call preventDefault in all on-tap events that show a dialog. (Closed)
Patch Set: nit Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/internet_page/network_siminfo.js
diff --git a/chrome/browser/resources/settings/internet_page/network_siminfo.js b/chrome/browser/resources/settings/internet_page/network_siminfo.js
index e0a2514efc7836edb3e0d1ad0b0ab7020ddfd4e5..8772be4c69a704c9089385d36108a00133f9b818 100644
--- a/chrome/browser/resources/settings/internet_page/network_siminfo.js
+++ b/chrome/browser/resources/settings/internet_page/network_siminfo.js
@@ -145,12 +145,13 @@ Polymer({
/**
* Opens the Change PIN dialog.
- * @param {Event} event
+ * @param {!Event} event
* @private
*/
onChangePinTap_: function(event) {
if (!this.networkProperties || !this.networkProperties.Cellular)
return;
+ event.preventDefault();
this.error_ = ErrorType.NONE;
this.$.changePinDialog.showModal();
this.$.changePinOld.value = '';
@@ -187,10 +188,11 @@ Polymer({
/**
* Opens the Unlock PIN dialog.
- * @param {Event} event
+ * @param {!Event} event
* @private
*/
onUnlockPinTap_: function(event) {
+ event.preventDefault();
this.error_ = ErrorType.NONE;
this.$.unlockPinDialog.showModal();
this.$.unlockPin.value = '';

Powered by Google App Engine
This is Rietveld 408576698