chrome/browser/resources/settings/device_page/display.js - Issue 2557073003: Call preventDefault in all on-tap events that show a dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/device_page/display.js

Issue 2557073003: Call preventDefault in all on-tap events that show a dialog. (Closed)

Patch Set: nit Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/settings/device_page/display.js

diff --git a/chrome/browser/resources/settings/device_page/display.js b/chrome/browser/resources/settings/device_page/display.js

index 24d437496603afb5de1d2bea01343dd6de8be547..6ad553b9eac1358ff4c46fde61b98a0fd1521a5e 100644

--- a/chrome/browser/resources/settings/device_page/display.js

+++ b/chrome/browser/resources/settings/device_page/display.js

@@ -370,8 +370,12 @@ Polymer({

id, properties, this.setPropertiesCallback_.bind(this));

- /** @private */

- onOverscanTap_: function() {

+ /**

+ * @param {!Event} e

+ * @private

+ */

+ onOverscanTap_: function(e) {

+ e.preventDefault();

this.overscanDisplayId = this.selectedDisplay.id;

this.showOverscanDialog_(true);