Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2424593002: Reduce FOR_EACH_OBSERVER usage in extensions (Closed)

Created:
4 years, 2 months ago by Eric Willigers
Modified:
4 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce FOR_EACH_OBSERVER usage in extensions Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/d1e2815e0685cff01fabe8a34c45ece45ef2d4b0 Cr-Commit-Position: refs/heads/master@{#425800}

Patch Set 1 #

Patch Set 2 : script_observers_ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -152 lines) Patch
M extensions/browser/api/audio/audio_service_chromeos.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M extensions/browser/api/display_source/display_source_apitestbase.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/networking_private/networking_private_linux.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M extensions/browser/api/networking_private/networking_private_service_client.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M extensions/browser/api/printer_provider_internal/printer_provider_internal_api.cc View 1 chunk +8 lines, -9 lines 0 comments Download
M extensions/browser/app_window/app_window_geometry_cache.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M extensions/browser/app_window/app_window_registry.cc View 2 chunks +12 lines, -7 lines 0 comments Download
M extensions/browser/extension_host.cc View 5 chunks +16 lines, -19 lines 0 comments Download
M extensions/browser/extension_icon_image.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M extensions/browser/extension_pref_value_map.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M extensions/browser/extension_prefs.cc View 8 chunks +16 lines, -24 lines 0 comments Download
M extensions/browser/extension_registry.cc View 4 chunks +15 lines, -20 lines 0 comments Download
M extensions/browser/process_manager.cc View 7 chunks +14 lines, -23 lines 0 comments Download
M extensions/browser/script_executor.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M extensions/browser/user_script_loader.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M extensions/browser/warning_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/components/native_app_window/native_app_window_views.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M extensions/renderer/user_script_set.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/renderer/user_script_set_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Eric Willigers
4 years, 2 months ago (2016-10-16 20:33:40 UTC) #10
asargent_no_longer_on_chrome
lgtm
4 years, 2 months ago (2016-10-17 20:46:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2424593002/20001
4 years, 2 months ago (2016-10-17 21:32:49 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-17 22:53:40 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 22:55:44 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d1e2815e0685cff01fabe8a34c45ece45ef2d4b0
Cr-Commit-Position: refs/heads/master@{#425800}

Powered by Google App Engine
This is Rietveld 408576698