extensions/renderer/user_script_set.cc - Issue 2424593002: Reduce FOR_EACH_OBSERVER usage in extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/user_script_set.cc

Issue 2424593002: Reduce FOR_EACH_OBSERVER usage in extensions (Closed)

Patch Set: script_observers_ Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/user_script_set.cc

diff --git a/extensions/renderer/user_script_set.cc b/extensions/renderer/user_script_set.cc

index cf10081267ea271bb22687c788d792d0f94c1b9b..8a7fdfbc2c1e700712bbdbf32abdf9e52bd4d8d4 100644

--- a/extensions/renderer/user_script_set.cc

+++ b/extensions/renderer/user_script_set.cc

@@ -156,8 +156,8 @@ bool UserScriptSet::UpdateUserScripts(base::SharedMemoryHandle shared_memory,

scripts_.push_back(std::move(script));

}

- FOR_EACH_OBSERVER(Observer, observers_,

- OnUserScriptsUpdated(changed_hosts, scripts_));

+ for (auto& observer : observers_)

+ observer.OnUserScriptsUpdated(changed_hosts, scripts_);

return true;

}