extensions/browser/api/networking_private/networking_private_linux.cc - Issue 2424593002: Reduce FOR_EACH_OBSERVER usage in extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/networking_private/networking_private_linux.cc

Issue 2424593002: Reduce FOR_EACH_OBSERVER usage in extensions (Closed)

Patch Set: script_observers_ Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/display_source/display_source_apitestbase.cc ('k') | extensions/browser/api/networking_private/networking_private_service_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/networking_private/networking_private_linux.cc

diff --git a/extensions/browser/api/networking_private/networking_private_linux.cc b/extensions/browser/api/networking_private/networking_private_linux.cc

index 2b8ccd7cd9b4dfdbe388df7277100b4d77427320..c6a467f7b8e2631f4d1ea617f83d0c91854e247e 100644

--- a/extensions/browser/api/networking_private/networking_private_linux.cc

+++ b/extensions/browser/api/networking_private/networking_private_linux.cc

@@ -1176,17 +1176,15 @@ bool NetworkingPrivateLinux::SetConnectionStateAndPostEvent(

void NetworkingPrivateLinux::OnNetworksChangedEventOnUIThread(

const GuidList& network_guids) {

DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

- FOR_EACH_OBSERVER(NetworkingPrivateDelegateObserver,

- network_events_observers_,

- OnNetworksChangedEvent(network_guids));

+ for (auto& observer : network_events_observers_)

+ observer.OnNetworksChangedEvent(network_guids);

}

void NetworkingPrivateLinux::OnNetworkListChangedEventOnUIThread(

const GuidList& network_guids) {

DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

- FOR_EACH_OBSERVER(NetworkingPrivateDelegateObserver,

- network_events_observers_,

- OnNetworkListChangedEvent(network_guids));

+ for (auto& observer : network_events_observers_)

+ observer.OnNetworkListChangedEvent(network_guids);

}

void NetworkingPrivateLinux::PostOnNetworksChangedToUIThread(