Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: extensions/browser/user_script_loader.cc

Issue 2424593002: Reduce FOR_EACH_OBSERVER usage in extensions (Closed)
Patch Set: script_observers_ Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/script_executor.cc ('k') | extensions/browser/warning_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/user_script_loader.cc
diff --git a/extensions/browser/user_script_loader.cc b/extensions/browser/user_script_loader.cc
index 92c7fc15db8c11d6c64cba92d7447b5ec4cf1510..0855deb9026a4324995a4e001e977b75ca4b2bbc 100644
--- a/extensions/browser/user_script_loader.cc
+++ b/extensions/browser/user_script_loader.cc
@@ -170,7 +170,8 @@ UserScriptLoader::UserScriptLoader(BrowserContext* browser_context,
}
UserScriptLoader::~UserScriptLoader() {
- FOR_EACH_OBSERVER(Observer, observers_, OnUserScriptLoaderDestroyed(this));
+ for (auto& observer : observers_)
+ observer.OnUserScriptLoaderDestroyed(this);
}
void UserScriptLoader::AddScripts(std::unique_ptr<UserScriptList> scripts) {
@@ -394,7 +395,8 @@ void UserScriptLoader::OnScriptsLoaded(
extensions::NOTIFICATION_USER_SCRIPTS_UPDATED,
content::Source<BrowserContext>(browser_context_),
content::Details<base::SharedMemory>(shared_memory_.get()));
- FOR_EACH_OBSERVER(Observer, observers_, OnScriptsLoaded(this));
+ for (auto& observer : observers_)
+ observer.OnScriptsLoaded(this);
}
void UserScriptLoader::SendUpdate(content::RenderProcessHost* process,
« no previous file with comments | « extensions/browser/script_executor.cc ('k') | extensions/browser/warning_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698