extensions/browser/warning_service.cc - Issue 2424593002: Reduce FOR_EACH_OBSERVER usage in extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/warning_service.cc

Issue 2424593002: Reduce FOR_EACH_OBSERVER usage in extensions (Closed)

Patch Set: script_observers_ Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/warning_service.cc

diff --git a/extensions/browser/warning_service.cc b/extensions/browser/warning_service.cc

index 8ba356aceab469c8715b164ab640c5487968893f..68422c89c986b8530f81e38c399345adff095a9e 100644

--- a/extensions/browser/warning_service.cc

+++ b/extensions/browser/warning_service.cc

@@ -117,8 +117,8 @@ void WarningService::RemoveObserver(Observer* observer) {

void WarningService::NotifyWarningsChanged(

const ExtensionIdSet& affected_extensions) {

- FOR_EACH_OBSERVER(Observer, observer_list_,

- ExtensionWarningsChanged(affected_extensions));

+ for (auto& observer : observer_list_)

+ observer.ExtensionWarningsChanged(affected_extensions);

}

void WarningService::OnExtensionUnloaded(