Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1090)

Side by Side Diff: extensions/browser/api/networking_private/networking_private_service_client.cc

Issue 2424593002: Reduce FOR_EACH_OBSERVER usage in extensions (Closed)
Patch Set: script_observers_ Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/api/networking_private/networking_private_service_c lient.h" 5 #include "extensions/browser/api/networking_private/networking_private_service_c lient.h"
6 6
7 #include "base/base64.h" 7 #include "base/base64.h"
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/sequenced_task_runner.h" 9 #include "base/sequenced_task_runner.h"
10 #include "base/threading/thread_task_runner_handle.h" 10 #include "base/threading/thread_task_runner_handle.h"
(...skipping 441 matching lines...) Expand 10 before | Expand all | Expand 10 after
452 } else { 452 } else {
453 DCHECK(!service_callbacks->start_disconnect_callback.is_null()); 453 DCHECK(!service_callbacks->start_disconnect_callback.is_null());
454 service_callbacks->start_disconnect_callback.Run(); 454 service_callbacks->start_disconnect_callback.Run();
455 } 455 }
456 RemoveServiceCallbacks(callback_id); 456 RemoveServiceCallbacks(callback_id);
457 } 457 }
458 458
459 void NetworkingPrivateServiceClient::OnNetworksChangedEventOnUIThread( 459 void NetworkingPrivateServiceClient::OnNetworksChangedEventOnUIThread(
460 const std::vector<std::string>& network_guids) { 460 const std::vector<std::string>& network_guids) {
461 DCHECK_CURRENTLY_ON(BrowserThread::UI); 461 DCHECK_CURRENTLY_ON(BrowserThread::UI);
462 FOR_EACH_OBSERVER(NetworkingPrivateDelegateObserver, 462 for (auto& observer : network_events_observers_)
463 network_events_observers_, 463 observer.OnNetworksChangedEvent(network_guids);
464 OnNetworksChangedEvent(network_guids));
465 } 464 }
466 465
467 void NetworkingPrivateServiceClient::OnNetworkListChangedEventOnUIThread( 466 void NetworkingPrivateServiceClient::OnNetworkListChangedEventOnUIThread(
468 const std::vector<std::string>& network_guids) { 467 const std::vector<std::string>& network_guids) {
469 DCHECK_CURRENTLY_ON(BrowserThread::UI); 468 DCHECK_CURRENTLY_ON(BrowserThread::UI);
470 FOR_EACH_OBSERVER(NetworkingPrivateDelegateObserver, 469 for (auto& observer : network_events_observers_)
471 network_events_observers_, 470 observer.OnNetworkListChangedEvent(network_guids);
472 OnNetworkListChangedEvent(network_guids));
473 } 471 }
474 472
475 } // namespace extensions 473 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698