Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3027)

Unified Diff: extensions/browser/api/printer_provider_internal/printer_provider_internal_api.cc

Issue 2424593002: Reduce FOR_EACH_OBSERVER usage in extensions (Closed)
Patch Set: script_observers_ Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/printer_provider_internal/printer_provider_internal_api.cc
diff --git a/extensions/browser/api/printer_provider_internal/printer_provider_internal_api.cc b/extensions/browser/api/printer_provider_internal/printer_provider_internal_api.cc
index db57e7f27bfed88a05e0b325beef39e663c74365..ff7eee7693a38336ba4c0a9b8690355d7a393c2a 100644
--- a/extensions/browser/api/printer_provider_internal/printer_provider_internal_api.cc
+++ b/extensions/browser/api/printer_provider_internal/printer_provider_internal_api.cc
@@ -67,33 +67,32 @@ void PrinterProviderInternalAPI::NotifyGetPrintersResult(
const Extension* extension,
int request_id,
const PrinterProviderInternalAPIObserver::PrinterInfoVector& printers) {
- FOR_EACH_OBSERVER(PrinterProviderInternalAPIObserver, observers_,
- OnGetPrintersResult(extension, request_id, printers));
+ for (auto& observer : observers_)
+ observer.OnGetPrintersResult(extension, request_id, printers);
}
void PrinterProviderInternalAPI::NotifyGetCapabilityResult(
const Extension* extension,
int request_id,
const base::DictionaryValue& capability) {
- FOR_EACH_OBSERVER(PrinterProviderInternalAPIObserver, observers_,
- OnGetCapabilityResult(extension, request_id, capability));
+ for (auto& observer : observers_)
+ observer.OnGetCapabilityResult(extension, request_id, capability);
}
void PrinterProviderInternalAPI::NotifyPrintResult(
const Extension* extension,
int request_id,
api::printer_provider_internal::PrintError error) {
- FOR_EACH_OBSERVER(PrinterProviderInternalAPIObserver, observers_,
- OnPrintResult(extension, request_id, error));
+ for (auto& observer : observers_)
+ observer.OnPrintResult(extension, request_id, error);
}
void PrinterProviderInternalAPI::NotifyGetUsbPrinterInfoResult(
const Extension* extension,
int request_id,
const api::printer_provider::PrinterInfo* printer_info) {
- FOR_EACH_OBSERVER(
- PrinterProviderInternalAPIObserver, observers_,
- OnGetUsbPrinterInfoResult(extension, request_id, printer_info));
+ for (auto& observer : observers_)
+ observer.OnGetUsbPrinterInfoResult(extension, request_id, printer_info);
}
PrinterProviderInternalReportPrintResultFunction::

Powered by Google App Engine
This is Rietveld 408576698