Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Side by Side Diff: extensions/browser/api/networking_private/networking_private_linux.cc

Issue 2424593002: Reduce FOR_EACH_OBSERVER usage in extensions (Closed)
Patch Set: script_observers_ Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/api/networking_private/networking_private_linux.h" 5 #include "extensions/browser/api/networking_private/networking_private_linux.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
(...skipping 1158 matching lines...) Expand 10 before | Expand all | Expand 10 after
1169 changed_networks->push_back(connected_network_guid); 1169 changed_networks->push_back(connected_network_guid);
1170 } 1170 }
1171 1171
1172 PostOnNetworksChangedToUIThread(std::move(changed_networks)); 1172 PostOnNetworksChangedToUIThread(std::move(changed_networks));
1173 return true; 1173 return true;
1174 } 1174 }
1175 1175
1176 void NetworkingPrivateLinux::OnNetworksChangedEventOnUIThread( 1176 void NetworkingPrivateLinux::OnNetworksChangedEventOnUIThread(
1177 const GuidList& network_guids) { 1177 const GuidList& network_guids) {
1178 DCHECK_CURRENTLY_ON(content::BrowserThread::UI); 1178 DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
1179 FOR_EACH_OBSERVER(NetworkingPrivateDelegateObserver, 1179 for (auto& observer : network_events_observers_)
1180 network_events_observers_, 1180 observer.OnNetworksChangedEvent(network_guids);
1181 OnNetworksChangedEvent(network_guids));
1182 } 1181 }
1183 1182
1184 void NetworkingPrivateLinux::OnNetworkListChangedEventOnUIThread( 1183 void NetworkingPrivateLinux::OnNetworkListChangedEventOnUIThread(
1185 const GuidList& network_guids) { 1184 const GuidList& network_guids) {
1186 DCHECK_CURRENTLY_ON(content::BrowserThread::UI); 1185 DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
1187 FOR_EACH_OBSERVER(NetworkingPrivateDelegateObserver, 1186 for (auto& observer : network_events_observers_)
1188 network_events_observers_, 1187 observer.OnNetworkListChangedEvent(network_guids);
1189 OnNetworkListChangedEvent(network_guids));
1190 } 1188 }
1191 1189
1192 void NetworkingPrivateLinux::PostOnNetworksChangedToUIThread( 1190 void NetworkingPrivateLinux::PostOnNetworksChangedToUIThread(
1193 std::unique_ptr<GuidList> guid_list) { 1191 std::unique_ptr<GuidList> guid_list) {
1194 AssertOnDBusThread(); 1192 AssertOnDBusThread();
1195 1193
1196 content::BrowserThread::PostTask( 1194 content::BrowserThread::PostTask(
1197 content::BrowserThread::UI, FROM_HERE, 1195 content::BrowserThread::UI, FROM_HERE,
1198 base::Bind(&NetworkingPrivateLinux::OnNetworksChangedEventTask, 1196 base::Bind(&NetworkingPrivateLinux::OnNetworksChangedEventTask,
1199 base::Unretained(this), base::Passed(&guid_list))); 1197 base::Unretained(this), base::Passed(&guid_list)));
1200 } 1198 }
1201 1199
1202 void NetworkingPrivateLinux::OnNetworksChangedEventTask( 1200 void NetworkingPrivateLinux::OnNetworksChangedEventTask(
1203 std::unique_ptr<GuidList> guid_list) { 1201 std::unique_ptr<GuidList> guid_list) {
1204 DCHECK_CURRENTLY_ON(content::BrowserThread::UI); 1202 DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
1205 OnNetworksChangedEventOnUIThread(*guid_list); 1203 OnNetworksChangedEventOnUIThread(*guid_list);
1206 } 1204 }
1207 1205
1208 } // namespace extensions 1206 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698