Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: extensions/browser/app_window/app_window_geometry_cache.cc

Issue 2424593002: Reduce FOR_EACH_OBSERVER usage in extensions (Closed)
Patch Set: script_observers_ Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/app_window/app_window_geometry_cache.cc
diff --git a/extensions/browser/app_window/app_window_geometry_cache.cc b/extensions/browser/app_window/app_window_geometry_cache.cc
index 87f055595670ee807b21be6b56ebec664b6f4b62..561034e1d12e268c7e0e710fd05c084e4aa2cc48 100644
--- a/extensions/browser/app_window/app_window_geometry_cache.cc
+++ b/extensions/browser/app_window/app_window_geometry_cache.cc
@@ -132,10 +132,8 @@ void AppWindowGeometryCache::SyncToStorage() {
"ts", base::Int64ToString(it->second.last_change.ToInternalValue()));
dict->SetWithoutPathExpansion(it->first, std::move(value));
- FOR_EACH_OBSERVER(
- Observer,
- observers_,
- OnGeometryCacheChanged(extension_id, it->first, bounds));
+ for (auto& observer : observers_)
+ observer.OnGeometryCacheChanged(extension_id, it->first, bounds);
}
prefs_->SetGeometryCache(extension_id, std::move(dict));

Powered by Google App Engine
This is Rietveld 408576698