Reduce FOR_EACH_OBSERVER usage in extensions

extensions/browser/extension_registry.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/extension_registry.h"
 
 #include "base/strings/string_util.h"
 #include "extensions/browser/extension_registry_factory.h"
 #include "extensions/browser/extension_registry_observer.h"
 
@@ skipping 33 matching lines @@
   observers_.AddObserver(observer);
 }
 
 void ExtensionRegistry::RemoveObserver(ExtensionRegistryObserver* observer) {
   observers_.RemoveObserver(observer);
 }
 
 void ExtensionRegistry::TriggerOnLoaded(const Extension* extension) {
   CHECK(extension);
   DCHECK(enabled_extensions_.Contains(extension->id()));
-  FOR_EACH_OBSERVER(ExtensionRegistryObserver,
-                    observers_,
-                    OnExtensionLoaded(browser_context_, extension));
+  for (auto& observer : observers_)
+    observer.OnExtensionLoaded(browser_context_, extension);
 }
 
 void ExtensionRegistry::TriggerOnReady(const Extension* extension) {
   CHECK(extension);
   DCHECK(enabled_extensions_.Contains(extension->id()));
-  FOR_EACH_OBSERVER(ExtensionRegistryObserver, observers_,
-                    OnExtensionReady(browser_context_, extension));
+  for (auto& observer : observers_)
+    observer.OnExtensionReady(browser_context_, extension);
 }
 
 void ExtensionRegistry::TriggerOnUnloaded(
     const Extension* extension,
     UnloadedExtensionInfo::Reason reason) {
   CHECK(extension);
   DCHECK(!enabled_extensions_.Contains(extension->id()));
-  FOR_EACH_OBSERVER(ExtensionRegistryObserver,
-                    observers_,
-                    OnExtensionUnloaded(browser_context_, extension, reason));
+  for (auto& observer : observers_)
+    observer.OnExtensionUnloaded(browser_context_, extension, reason);
 }
 
 void ExtensionRegistry::TriggerOnWillBeInstalled(const Extension* extension,
                                                  bool is_update,
                                                  const std::string& old_name) {
   CHECK(extension);
   DCHECK_EQ(is_update,
             GenerateInstalledExtensionsSet()->Contains(extension->id()));
   DCHECK_EQ(is_update, !old_name.empty());
-  FOR_EACH_OBSERVER(ExtensionRegistryObserver, observers_,
-                    OnExtensionWillBeInstalled(browser_context_, extension,
-                                               is_update, old_name));
+  for (auto& observer : observers_)
+    observer.OnExtensionWillBeInstalled(browser_context_, extension, is_update,
+                                        old_name);
 }
 
 void ExtensionRegistry::TriggerOnInstalled(const Extension* extension,
                                            bool is_update) {
   CHECK(extension);
   DCHECK(GenerateInstalledExtensionsSet()->Contains(extension->id()));
-  FOR_EACH_OBSERVER(ExtensionRegistryObserver,
-                    observers_,
-                    OnExtensionInstalled(
-                        browser_context_, extension, is_update));
+  for (auto& observer : observers_)
+    observer.OnExtensionInstalled(browser_context_, extension, is_update);
 }
 
 void ExtensionRegistry::TriggerOnUninstalled(const Extension* extension,
                                              UninstallReason reason) {
   CHECK(extension);
   DCHECK(!GenerateInstalledExtensionsSet()->Contains(extension->id()));
-  FOR_EACH_OBSERVER(
-      ExtensionRegistryObserver,
-      observers_,
-      OnExtensionUninstalled(browser_context_, extension, reason));
+  for (auto& observer : observers_)
+    observer.OnExtensionUninstalled(browser_context_, extension, reason);
 }
 
 const Extension* ExtensionRegistry::GetExtensionById(const std::string& id,
                                                      int include_mask) const {
   std::string lowercase_id = base::ToLowerASCII(id);
   if (include_mask & ENABLED) {
     const Extension* extension = enabled_extensions_.GetByID(lowercase_id);
     if (extension)
       return extension;
   }
@@ skipping 88 matching lines @@
   disabled_extensions_.Clear();
   terminated_extensions_.Clear();
   blacklisted_extensions_.Clear();
   blocked_extensions_.Clear();
   ready_extensions_.Clear();
 }
 
 void ExtensionRegistry::Shutdown() {
   // Release references to all Extension objects in the sets.
   ClearAll();
-  FOR_EACH_OBSERVER(ExtensionRegistryObserver, observers_, OnShutdown(this));
+  for (auto& observer : observers_)
+    observer.OnShutdown(this);
 }
 
 }  // namespace extensions