Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1065)

Unified Diff: extensions/browser/app_window/app_window_registry.cc

Issue 2424593002: Reduce FOR_EACH_OBSERVER usage in extensions (Closed)
Patch Set: script_observers_ Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/app_window/app_window_geometry_cache.cc ('k') | extensions/browser/extension_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/app_window/app_window_registry.cc
diff --git a/extensions/browser/app_window/app_window_registry.cc b/extensions/browser/app_window/app_window_registry.cc
index 6fc0dedccfabd7cb140f09bdbd72a3a79e94435e..c02424291bf7c52fc8c6c4668859b488e2a3e171 100644
--- a/extensions/browser/app_window/app_window_registry.cc
+++ b/extensions/browser/app_window/app_window_registry.cc
@@ -62,26 +62,30 @@ AppWindowRegistry* AppWindowRegistry::Get(content::BrowserContext* context) {
void AppWindowRegistry::AddAppWindow(AppWindow* app_window) {
BringToFront(app_window);
- FOR_EACH_OBSERVER(Observer, observers_, OnAppWindowAdded(app_window));
+ for (auto& observer : observers_)
+ observer.OnAppWindowAdded(app_window);
}
void AppWindowRegistry::AppWindowIconChanged(AppWindow* app_window) {
AddAppWindowToList(app_window);
- FOR_EACH_OBSERVER(Observer, observers_, OnAppWindowIconChanged(app_window));
+ for (auto& observer : observers_)
+ observer.OnAppWindowIconChanged(app_window);
}
void AppWindowRegistry::AppWindowActivated(AppWindow* app_window) {
BringToFront(app_window);
- FOR_EACH_OBSERVER(Observer, observers_, OnAppWindowActivated(app_window));
+ for (auto& observer : observers_)
+ observer.OnAppWindowActivated(app_window);
}
void AppWindowRegistry::AppWindowHidden(AppWindow* app_window) {
- FOR_EACH_OBSERVER(Observer, observers_, OnAppWindowHidden(app_window));
+ for (auto& observer : observers_)
+ observer.OnAppWindowHidden(app_window);
}
void AppWindowRegistry::AppWindowShown(AppWindow* app_window, bool was_hidden) {
- FOR_EACH_OBSERVER(Observer, observers_,
- OnAppWindowShown(app_window, was_hidden));
+ for (auto& observer : observers_)
+ observer.OnAppWindowShown(app_window, was_hidden);
}
void AppWindowRegistry::RemoveAppWindow(AppWindow* app_window) {
@@ -89,7 +93,8 @@ void AppWindowRegistry::RemoveAppWindow(AppWindow* app_window) {
std::find(app_windows_.begin(), app_windows_.end(), app_window);
if (it != app_windows_.end())
app_windows_.erase(it);
- FOR_EACH_OBSERVER(Observer, observers_, OnAppWindowRemoved(app_window));
+ for (auto& observer : observers_)
+ observer.OnAppWindowRemoved(app_window);
}
void AppWindowRegistry::AddObserver(Observer* observer) {
« no previous file with comments | « extensions/browser/app_window/app_window_geometry_cache.cc ('k') | extensions/browser/extension_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698