Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: extensions/components/native_app_window/native_app_window_views.cc

Issue 2424593002: Reduce FOR_EACH_OBSERVER usage in extensions (Closed)
Patch Set: script_observers_ Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/warning_service.cc ('k') | extensions/renderer/user_script_set.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/components/native_app_window/native_app_window_views.cc
diff --git a/extensions/components/native_app_window/native_app_window_views.cc b/extensions/components/native_app_window/native_app_window_views.cc
index 902134211d5e65c39693b3a4b63e6ec2e43c4f32..f4abafac3c9ae2539b15b033ee1fbf5682effa73 100644
--- a/extensions/components/native_app_window/native_app_window_views.cc
+++ b/extensions/components/native_app_window/native_app_window_views.cc
@@ -194,9 +194,8 @@ void NativeAppWindowViews::RemoveObserver(
}
void NativeAppWindowViews::OnViewWasResized() {
- FOR_EACH_OBSERVER(web_modal::ModalDialogHostObserver,
- observer_list_,
- OnPositionRequiresUpdate());
+ for (auto& observer : observer_list_)
+ observer.OnPositionRequiresUpdate();
}
// WidgetDelegate implementation.
@@ -272,9 +271,8 @@ bool NativeAppWindowViews::ShouldDescendIntoChildForEventHandling(
// WidgetObserver implementation.
void NativeAppWindowViews::OnWidgetDestroying(views::Widget* widget) {
- FOR_EACH_OBSERVER(web_modal::ModalDialogHostObserver,
- observer_list_,
- OnHostDestroying());
+ for (auto& observer : observer_list_)
+ observer.OnHostDestroying();
}
void NativeAppWindowViews::OnWidgetVisibilityChanged(views::Widget* widget,
« no previous file with comments | « extensions/browser/warning_service.cc ('k') | extensions/renderer/user_script_set.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698