Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: extensions/browser/api/audio/audio_service_chromeos.cc

Issue 2424593002: Reduce FOR_EACH_OBSERVER usage in extensions (Closed)
Patch Set: script_observers_ Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/browser/api/display_source/display_source_apitestbase.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/audio/audio_service_chromeos.cc
diff --git a/extensions/browser/api/audio/audio_service_chromeos.cc b/extensions/browser/api/audio/audio_service_chromeos.cc
index 5d3d37f3a0f64abefcae76b682c662419b877465..0a17972dd544123031d89b802cde5b35cce32f2e 100644
--- a/extensions/browser/api/audio/audio_service_chromeos.cc
+++ b/extensions/browser/api/audio/audio_service_chromeos.cc
@@ -222,12 +222,13 @@ void AudioServiceImpl::OnActiveInputNodeChanged() {
}
void AudioServiceImpl::NotifyDeviceChanged() {
- FOR_EACH_OBSERVER(AudioService::Observer, observer_list_, OnDeviceChanged());
+ for (auto& observer : observer_list_)
+ observer.OnDeviceChanged();
}
void AudioServiceImpl::NotifyLevelChanged(uint64_t id, int level) {
- FOR_EACH_OBSERVER(AudioService::Observer, observer_list_,
- OnLevelChanged(base::Uint64ToString(id), level));
+ for (auto& observer : observer_list_)
+ observer.OnLevelChanged(base::Uint64ToString(id), level);
// Notify DeviceChanged event for backward compatibility.
// TODO(jennyz): remove this code when the old version of hotrod retires.
@@ -235,8 +236,8 @@ void AudioServiceImpl::NotifyLevelChanged(uint64_t id, int level) {
}
void AudioServiceImpl::NotifyMuteChanged(bool is_input, bool is_muted) {
- FOR_EACH_OBSERVER(AudioService::Observer, observer_list_,
- OnMuteChanged(is_input, is_muted));
+ for (auto& observer : observer_list_)
+ observer.OnMuteChanged(is_input, is_muted);
// Notify DeviceChanged event for backward compatibility.
// TODO(jennyz): remove this code when the old version of hotrod retires.
@@ -273,8 +274,8 @@ void AudioServiceImpl::NotifyDevicesChanged() {
devices_info_list.push_back(std::move(info));
}
- FOR_EACH_OBSERVER(AudioService::Observer, observer_list_,
- OnDevicesChanged(devices_info_list));
+ for (auto& observer : observer_list_)
+ observer.OnDevicesChanged(devices_info_list);
// Notify DeviceChanged event for backward compatibility.
// TODO(jennyz): remove this code when the old version of hotrod retires.
« no previous file with comments | « no previous file | extensions/browser/api/display_source/display_source_apitestbase.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698