Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: extensions/browser/extension_icon_image.cc

Issue 2424593002: Reduce FOR_EACH_OBSERVER usage in extensions (Closed)
Patch Set: script_observers_ Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/extension_host.cc ('k') | extensions/browser/extension_pref_value_map.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/extension_icon_image.cc
diff --git a/extensions/browser/extension_icon_image.cc b/extensions/browser/extension_icon_image.cc
index 94e648992ff43945e940b81206d0665d9720a366..2d4aa174514463d147bfde93d8798e0882ea9439 100644
--- a/extensions/browser/extension_icon_image.cc
+++ b/extensions/browser/extension_icon_image.cc
@@ -163,7 +163,8 @@ void IconImage::RemoveObserver(Observer* observer) {
}
IconImage::~IconImage() {
- FOR_EACH_OBSERVER(Observer, observers_, OnExtensionIconImageDestroyed(this));
+ for (auto& observer : observers_)
+ observer.OnExtensionIconImageDestroyed(this);
source_->ResetHost();
}
@@ -247,7 +248,8 @@ void IconImage::OnImageLoaded(float scale, const gfx::Image& image_in) {
// there's no way to combine the storage of two images.
image_ = gfx::Image(image_skia_);
- FOR_EACH_OBSERVER(Observer, observers_, OnExtensionIconImageChanged(this));
+ for (auto& observer : observers_)
+ observer.OnExtensionIconImageChanged(this);
}
void IconImage::Observe(int type,
« no previous file with comments | « extensions/browser/extension_host.cc ('k') | extensions/browser/extension_pref_value_map.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698