Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 23799009: Always pass v8::Isolate to v8::Number::New() (Closed)

Created:
7 years, 3 months ago by do-not-use
Modified:
7 years, 3 months ago
CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, Nate Chapin
Visibility:
Public.

Description

Always pass v8::Isolate to v8::Number::New() Always pass v8::Isolate to v8::Number::New() as this is now the preferred way of constructing a Number: https://code.google.com/p/v8/issues/detail?id=2487 R=haraken BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157550

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -27 lines) Patch
M Source/bindings/scripts/deprecated_code_generator_v8.pm View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/scripts/v8_types.py View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/bindings/tests/idls/TestCallback.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestCallback.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestCallback.cpp View 1 chunk +29 lines, -0 lines 0 comments Download
M Source/bindings/v8/IDBBindingUtilities.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/ScriptFunctionCall.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/bindings/v8/SerializedScriptValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8AbstractEventListener.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/v8/V8Binding.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/bindings/v8/V8NPObject.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8IDBAnyCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8InjectedScriptManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8SQLResultSetRowListCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebBindings.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
do-not-use
7 years, 3 months ago (2013-09-10 12:55:54 UTC) #1
arv (Not doing code reviews)
LGTM However, I've always wondered why we need an isolate for number, string, boolean, undefined ...
7 years, 3 months ago (2013-09-10 13:11:19 UTC) #2
haraken
LGTM. > However, I've always wondered why we need an isolate for number, string, > ...
7 years, 3 months ago (2013-09-10 13:57:42 UTC) #3
do-not-use
abarth@, could you please approve the Source/web bits?
7 years, 3 months ago (2013-09-10 13:59:29 UTC) #4
abarth-chromium
Source/web <--- LGTM :)
7 years, 3 months ago (2013-09-10 16:25:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23799009/1
7 years, 3 months ago (2013-09-10 19:23:44 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-10 21:09:01 UTC) #7
Message was sent while issue was closed.
Change committed as 157550

Powered by Google App Engine
This is Rietveld 408576698