Source/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp - Issue 23799009: Always pass v8::Isolate to v8::Number::New()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp

Issue 23799009: Always pass v8::Isolate to v8::Number::New() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp

diff --git a/Source/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp b/Source/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp

index 510bdb98101404a04085f788f6fb27130b24f2da..3baa1ead24475398ff4079c5b2c48aca01ae897e 100644

--- a/Source/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp

+++ b/Source/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp

@@ -134,7 +134,7 @@ static v8::Handle<v8::Value> toV8Object(const WebGLGetInfo& info, v8::Handle<v8:

return array;

}

case WebGLGetInfo::kTypeFloat:

- return v8::Number::New(info.getFloat());

+ return v8::Number::New(isolate, info.getFloat());

case WebGLGetInfo::kTypeInt:

return v8::Integer::New(info.getInt(), isolate);

case WebGLGetInfo::kTypeNull: