Source/bindings/v8/custom/V8InjectedScriptManager.cpp - Issue 23799009: Always pass v8::Isolate to v8::Number::New()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8InjectedScriptManager.cpp

Issue 23799009: Always pass v8::Isolate to v8::Number::New() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp ('k') | Source/bindings/v8/custom/V8SQLResultSetRowListCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/v8/custom/V8InjectedScriptManager.cpp

diff --git a/Source/bindings/v8/custom/V8InjectedScriptManager.cpp b/Source/bindings/v8/custom/V8InjectedScriptManager.cpp

index 7316fc94504fc771eba65a86d39dc8deffb991f4..5b551dad5cfb97c1f7bf532e411c45f70ffd55f8 100644

--- a/Source/bindings/v8/custom/V8InjectedScriptManager.cpp

+++ b/Source/bindings/v8/custom/V8InjectedScriptManager.cpp

@@ -92,7 +92,7 @@ ScriptObject InjectedScriptManager::createInjectedScript(const String& scriptSou

ASSERT(value->IsFunction());

v8::Local<v8::Object> windowGlobal = inspectedContext->Global();

- v8::Handle<v8::Value> args[] = { scriptHostWrapper, windowGlobal, v8::Number::New(id) };

+ v8::Handle<v8::Value> args[] = { scriptHostWrapper, windowGlobal, v8::Number::New(inspectedContext->GetIsolate(), id) };

v8::Local<v8::Value> injectedScriptValue = V8ScriptRunner::callInternalFunction(v8::Local<v8::Function>::Cast(value), windowGlobal, WTF_ARRAY_LENGTH(args), args, inspectedContext->GetIsolate());

return ScriptObject(inspectedScriptState, v8::Handle<v8::Object>::Cast(injectedScriptValue));

}