Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Side by Side Diff: Source/web/WebBindings.cpp

Issue 23799009: Always pass v8::Isolate to v8::Number::New() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 298 matching lines...) Expand 10 before | Expand all | Expand 10 after
309 309
310 *arrayBufferView = WebArrayBufferView(native); 310 *arrayBufferView = WebArrayBufferView(native);
311 return true; 311 return true;
312 } 312 }
313 313
314 static NPObject* makeIntArrayImpl(const WebVector<int>& data, v8::Isolate* isola te) 314 static NPObject* makeIntArrayImpl(const WebVector<int>& data, v8::Isolate* isola te)
315 { 315 {
316 v8::HandleScope handleScope(isolate); 316 v8::HandleScope handleScope(isolate);
317 v8::Handle<v8::Array> result = v8::Array::New(data.size()); 317 v8::Handle<v8::Array> result = v8::Array::New(data.size());
318 for (size_t i = 0; i < data.size(); ++i) 318 for (size_t i = 0; i < data.size(); ++i)
319 result->Set(i, v8::Number::New(data[i])); 319 result->Set(i, v8::Number::New(isolate, data[i]));
320 320
321 DOMWindow* window = toDOMWindow(isolate->GetCurrentContext()); 321 DOMWindow* window = toDOMWindow(isolate->GetCurrentContext());
322 return npCreateV8ScriptObject(0, result, window); 322 return npCreateV8ScriptObject(0, result, window);
323 } 323 }
324 324
325 static NPObject* makeStringArrayImpl(const WebVector<WebString>& data, v8::Isola te* isolate) 325 static NPObject* makeStringArrayImpl(const WebVector<WebString>& data, v8::Isola te* isolate)
326 { 326 {
327 v8::HandleScope handleScope(isolate); 327 v8::HandleScope handleScope(isolate);
328 v8::Handle<v8::Array> result = v8::Array::New(data.size()); 328 v8::Handle<v8::Array> result = v8::Array::New(data.size());
329 for (size_t i = 0; i < data.size(); ++i) 329 for (size_t i = 0; i < data.size(); ++i)
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
392 if (!v8Object) 392 if (!v8Object)
393 return v8::Undefined(); 393 return v8::Undefined();
394 return convertNPVariantToV8Object(variant, v8Object->rootObject->frame() ->script()->windowScriptNPObject(), isolate); 394 return convertNPVariantToV8Object(variant, v8Object->rootObject->frame() ->script()->windowScriptNPObject(), isolate);
395 } 395 }
396 // Safe to pass 0 since we have checked the script object class to make sure the 396 // Safe to pass 0 since we have checked the script object class to make sure the
397 // argument is a primitive v8 type. 397 // argument is a primitive v8 type.
398 return convertNPVariantToV8Object(variant, 0, isolate); 398 return convertNPVariantToV8Object(variant, 0, isolate);
399 } 399 }
400 400
401 } // namespace WebKit 401 } // namespace WebKit
OLDNEW
« no previous file with comments | « Source/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698