Source/bindings/v8/custom/V8SQLResultSetRowListCustom.cpp - Issue 23799009: Always pass v8::Isolate to v8::Number::New()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8SQLResultSetRowListCustom.cpp

Issue 23799009: Always pass v8::Isolate to v8::Number::New() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/custom/V8SQLResultSetRowListCustom.cpp

diff --git a/Source/bindings/v8/custom/V8SQLResultSetRowListCustom.cpp b/Source/bindings/v8/custom/V8SQLResultSetRowListCustom.cpp

index 01c452c022714dfa293d6ac8bbcca80d1f13b21d..c56441e03a190042457de1126d7c366c06d2b972 100644

--- a/Source/bindings/v8/custom/V8SQLResultSetRowListCustom.cpp

+++ b/Source/bindings/v8/custom/V8SQLResultSetRowListCustom.cpp

@@ -72,7 +72,7 @@ void V8SQLResultSetRowList::itemMethodCustom(const v8::FunctionCallbackInfo<v8::

value = v8::Null(args.GetIsolate());

break;

case SQLValue::NumberValue:

- value = v8::Number::New(sqlValue.number());

+ value = v8::Number::New(args.GetIsolate(), sqlValue.number());

break;

default:

ASSERT_NOT_REACHED();