Source/bindings/tests/results/V8TestCallback.h - Issue 23799009: Always pass v8::Isolate to v8::Number::New()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestCallback.h

Issue 23799009: Always pass v8::Isolate to v8::Number::New() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/tests/results/V8TestCallback.h

diff --git a/Source/bindings/tests/results/V8TestCallback.h b/Source/bindings/tests/results/V8TestCallback.h

index 7986f1fefc21dc4113dfc05020b1cad793c663c2..6e6388b3d7d763df4d10d4ba7a09f3d2dfb37c84 100644

--- a/Source/bindings/tests/results/V8TestCallback.h

+++ b/Source/bindings/tests/results/V8TestCallback.h

@@ -50,6 +50,7 @@ public:

virtual bool callbackWithStringList(RefPtr<DOMStringList> listParam);

virtual bool callbackWithBoolean(bool boolParam);

virtual bool callbackWithSequence(const Vector<RefPtr<TestObj> >& sequenceParam);

+ virtual bool callbackWithFloat(float floatParam);

virtual bool callbackWithThisArg(ScriptValue thisValue, int param);

virtual ScriptExecutionContext* scriptExecutionContext() const { return ContextLifecycleObserver::scriptExecutionContext(); }