Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: Source/bindings/scripts/deprecated_code_generator_v8.pm

Issue 23799009: Always pass v8::Isolate to v8::Number::New() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/scripts/v8_types.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/deprecated_code_generator_v8.pm
diff --git a/Source/bindings/scripts/deprecated_code_generator_v8.pm b/Source/bindings/scripts/deprecated_code_generator_v8.pm
index 14fb7f30cac7fefd501d53eb8fcaefb454ef7fbe..e1973715d34cacf44cc6ff67d877bb026f173504 100644
--- a/Source/bindings/scripts/deprecated_code_generator_v8.pm
+++ b/Source/bindings/scripts/deprecated_code_generator_v8.pm
@@ -5422,13 +5422,13 @@ sub NativeToJSValue
# long long and unsigned long long are not representable in ECMAScript.
if ($type eq "long long" or $type eq "unsigned long long" or $type eq "DOMTimeStamp") {
return "${indent}v8SetReturnValue(${getCallbackInfo}, static_cast<double>($nativeValue));" if $isReturnValue;
- return "$indent$receiver v8::Number::New(static_cast<double>($nativeValue));";
+ return "$indent$receiver v8::Number::New($getIsolate, static_cast<double>($nativeValue));";
}
if (IsPrimitiveType($type)) {
die "unexpected type $type" if not ($type eq "float" or $type eq "double");
return "${indent}v8SetReturnValue(${getCallbackInfo}, ${nativeValue});" if $isReturnValue;
- return "$indent$receiver v8::Number::New($nativeValue);";
+ return "$indent$receiver v8::Number::New($getIsolate, $nativeValue);";
}
if ($nativeType eq "ScriptValue" or $nativeType eq "ScriptPromise") {
« no previous file with comments | « no previous file | Source/bindings/scripts/v8_types.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698