Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: Source/bindings/v8/SerializedScriptValue.cpp

Issue 23799009: Always pass v8::Isolate to v8::Number::New() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/bindings/v8/ScriptFunctionCall.cpp ('k') | Source/bindings/v8/V8AbstractEventListener.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 1690 matching lines...) Expand 10 before | Expand all | Expand 10 after
1701 return false; 1701 return false;
1702 *value = v8::Date::New(numberValue); 1702 *value = v8::Date::New(numberValue);
1703 return true; 1703 return true;
1704 } 1704 }
1705 1705
1706 bool readNumber(v8::Handle<v8::Value>* value) 1706 bool readNumber(v8::Handle<v8::Value>* value)
1707 { 1707 {
1708 double number; 1708 double number;
1709 if (!doReadNumber(&number)) 1709 if (!doReadNumber(&number))
1710 return false; 1710 return false;
1711 *value = v8::Number::New(number); 1711 *value = v8::Number::New(m_isolate, number);
1712 return true; 1712 return true;
1713 } 1713 }
1714 1714
1715 bool readNumberObject(v8::Handle<v8::Value>* value) 1715 bool readNumberObject(v8::Handle<v8::Value>* value)
1716 { 1716 {
1717 double number; 1717 double number;
1718 if (!doReadNumber(&number)) 1718 if (!doReadNumber(&number))
1719 return false; 1719 return false;
1720 *value = v8::NumberObject::New(number); 1720 *value = v8::NumberObject::New(number);
1721 return true; 1721 return true;
(...skipping 820 matching lines...) Expand 10 before | Expand all | Expand 10 after
2542 v8::V8::AdjustAmountOfExternalAllocatedMemory(-m_externallyAllocatedMemo ry); 2542 v8::V8::AdjustAmountOfExternalAllocatedMemory(-m_externallyAllocatedMemo ry);
2543 } 2543 }
2544 } 2544 }
2545 2545
2546 uint32_t SerializedScriptValue::wireFormatVersion() 2546 uint32_t SerializedScriptValue::wireFormatVersion()
2547 { 2547 {
2548 return WebCore::wireFormatVersion; 2548 return WebCore::wireFormatVersion;
2549 } 2549 }
2550 2550
2551 } // namespace WebCore 2551 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/v8/ScriptFunctionCall.cpp ('k') | Source/bindings/v8/V8AbstractEventListener.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698