Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Side by Side Diff: Source/bindings/v8/custom/V8SQLResultSetRowListCustom.cpp

Issue 23799009: Always pass v8::Isolate to v8::Number::New() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 const SQLValue& sqlValue = rowList->values()[valuesIndex + i]; 65 const SQLValue& sqlValue = rowList->values()[valuesIndex + i];
66 v8::Handle<v8::Value> value; 66 v8::Handle<v8::Value> value;
67 switch(sqlValue.type()) { 67 switch(sqlValue.type()) {
68 case SQLValue::StringValue: 68 case SQLValue::StringValue:
69 value = v8String(sqlValue.string(), args.GetIsolate()); 69 value = v8String(sqlValue.string(), args.GetIsolate());
70 break; 70 break;
71 case SQLValue::NullValue: 71 case SQLValue::NullValue:
72 value = v8::Null(args.GetIsolate()); 72 value = v8::Null(args.GetIsolate());
73 break; 73 break;
74 case SQLValue::NumberValue: 74 case SQLValue::NumberValue:
75 value = v8::Number::New(sqlValue.number()); 75 value = v8::Number::New(args.GetIsolate(), sqlValue.number());
76 break; 76 break;
77 default: 77 default:
78 ASSERT_NOT_REACHED(); 78 ASSERT_NOT_REACHED();
79 } 79 }
80 80
81 item->Set(v8String(rowList->columnNames()[i], args.GetIsolate()), value, static_cast<v8::PropertyAttribute>(v8::DontDelete | v8::ReadOnly)); 81 item->Set(v8String(rowList->columnNames()[i], args.GetIsolate()), value, static_cast<v8::PropertyAttribute>(v8::DontDelete | v8::ReadOnly));
82 } 82 }
83 83
84 v8SetReturnValue(args, item); 84 v8SetReturnValue(args, item);
85 } 85 }
86 86
87 } // namespace WebCore 87 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/v8/custom/V8InjectedScriptManager.cpp ('k') | Source/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698